ruby on rails - How can I improve my "newname" method -
i student , got memo (without explanation) following code bugged , can better. how improve controller#newname method? thank time!
class reviewcontroller < applicationcontroller def index @reviews = review.all.order(created_at: :desc) end def newname @review = review.find(params[:id]) if @review.update_attribute(:title, sanitize(params[:title])) format.json { render json: { status: 200 } } else format.json { render json: { status: 500 } } end end end
the biggest flaw update_attribute skips validations, hence, else statement rarely/never executed. change to:
@review.name = sanitize(params[:title]) if @review.save #... and should better.
Comments
Post a Comment