c - Variable (short) changes values when copied/assigned -


i have following code: 

  short num_short = 1;   int possible_new_short = 1;   valid = 1;    while (valid) {     possible_new_short = num_short * 10;     printf("----\n");     printf("num short: %d\n", num_short);     printf("possible new short: %d\n", possible_new_short);     if (possible_new_short % 10 == 0) {       num_short = possible_new_short;       printf("new! %d\n", num_short);     } else {       valid = 0;     }     if (num_short == 0) {       valid = 0;     }   }   printf("num_short: %d\n", num_short);

the output follows:

---- num short: 1 possible new short: 10 new! 10 ---- num short: 10 possible new short: 100 new! 100 ---- num short: 100 possible new short: 1000 new! 1000 ---- num short: 1000 possible new short: 10000 new! 10000 ---- num short: 10000 possible new short: 100000 new! -31072 ----

as can see, value of possible_new_short 100000, when reassigned num_short goes -31072. why happening?

i'm new c , guess num_short variable overflowed. because num_short , possible_new_short stored in different slots of memory, 1 can overflow , 1 can't?

what best practices guard against this?

your guess correct, num_short of type short, 16-bit in machines today.

a 16-bit signed integer can hold values @ 215 − 1, 32767. last value 100000 overflows.

possible_new_short doesn't overflow because type int. in general, think maximum possible values variable holds, , define type accordingly. example, can use long or long long instead.


Comments

Post a Comment

Popular posts from this blog

Magento/PHP - Get phones on all members in a customer group -

i working on custom magento extension. working around adminhtml part , i've created custom form there. here form code: <?php class vivasindustries_smsnotification_block_adminhtml_sms_sendmass_edit_form extends mage_adminhtml_block_widget_form { public function _preparelayout() { $extensionpath = mage::getmoduledir('js', 'vivasindustries_smsnotification'); $head = $this->getlayout()->getblock('head'); $head->addjs('jquery.js'); $head->addjs('vivas.js'); return parent::_preparelayout(); } protected function _prepareform() { $form = new varien_data_form(array( 'id' => 'edit_form', 'action' => $this->geturl('*/*/save', array('id' => $this->getrequest()->get...
Read more

php - Bypass Geo Redirect for specific directories -

i'm trying bypass redirect specific url within site. wondering if might able help. the code below code use, original urls replaces example.com i'd able access http://example.com/admin without redirect occuring. is there way this, , there way using own ip? function country_geo_redirect() { $country = getenv('http_geoip_country_code'); if ($country == "us" ) { wp_redirect("http://usa.example.com/"); exit; } else if ($country == "gb" ) { wp_redirect("http://uk.example.com/"); exit; } } add_action('init', 'country_geo_redirect'); you can bypass redirection code if server found ip address. if ip address == <my ip address> ' nothing here else country_georedirect() end if
Read more

php - .htaccess mod_rewrite for dynamic url which has domain names -

i want convert url ex:( example.com/link.php?url=facebook.com ) ( example.com/facebook.com.php ) how can using .htaccess. or there other process make job easier ? i tried adding script .htaccess file options +followsymlinks rewriteengine on rewriterule url-(.*)\.htm$ link.php?url=$1 but converting url adding "url-" ( example.com/url-facebook.com.php ) i want remove "url-" , want make ( example.com/facebook.com.php ) rewriteengine on rewritecond %{the_request} ^get.*link\.php\?url\= [nc] rewritecond %{request_uri} !/system/.* [nc] rewriterule (.*?)link\.php\?url\=/*(.*) /$1$2 [r=301,ne,l] not sure how above work edit of used use remove index.php url
Read more