javascript - function not being called, do I need a window.load? -


i trying change css stylings of item when it's clicked.

ryan.js

function ryanclicked(id){     document.getelementbyid(id).style.color = "blue";     alert("asdsa"); }

product.html

<head>     <script src="ryan.js"></script> </head> <body>     <div id ="sizebutton1"class="sizebutton" onclick="ryanclicked(sizebutton1)"> s </div>     <div id ="sizebutton2"class="sizebutton" onclick="ryanclicked(sizebutton2)"> m </div>     <div id ="sizebutton3"class="sizebutton" onclick="ryanclicked(sizebutton3)"> l </div>

i assume need onready or onload somewhere? haven't done js in while. page has jquery included can use jquery ready event. i'm not sure if better or not.

try this, don't need pass id function, instead can pass this (refers element clicked), 

function ryanclicked(el) {    el.style.color = "blue";  }
<div id="sizebutton1"class="sizebutton" onclick="ryanclicked(this)">s</div>  <div id="sizebutton2"class="sizebutton" onclick="ryanclicked(this)">m</div>  <div id="sizebutton3"class="sizebutton" onclick="ryanclicked(this)">l</div>


Comments

Post a Comment

Popular posts from this blog

Magento/PHP - Get phones on all members in a customer group -

i working on custom magento extension. working around adminhtml part , i've created custom form there. here form code: <?php class vivasindustries_smsnotification_block_adminhtml_sms_sendmass_edit_form extends mage_adminhtml_block_widget_form { public function _preparelayout() { $extensionpath = mage::getmoduledir('js', 'vivasindustries_smsnotification'); $head = $this->getlayout()->getblock('head'); $head->addjs('jquery.js'); $head->addjs('vivas.js'); return parent::_preparelayout(); } protected function _prepareform() { $form = new varien_data_form(array( 'id' => 'edit_form', 'action' => $this->geturl('*/*/save', array('id' => $this->getrequest()->get
Read more

php - .htaccess mod_rewrite for dynamic url which has domain names -

i want convert url ex:( example.com/link.php?url=facebook.com ) ( example.com/facebook.com.php ) how can using .htaccess. or there other process make job easier ? i tried adding script .htaccess file options +followsymlinks rewriteengine on rewriterule url-(.*)\.htm$ link.php?url=$1 but converting url adding "url-" ( example.com/url-facebook.com.php ) i want remove "url-" , want make ( example.com/facebook.com.php ) rewriteengine on rewritecond %{the_request} ^get.*link\.php\?url\= [nc] rewritecond %{request_uri} !/system/.* [nc] rewriterule (.*?)link\.php\?url\=/*(.*) /$1$2 [r=301,ne,l] not sure how above work edit of used use remove index.php url
Read more

Website Login Issue developed in magento -

i have website developed using magento . able login. right now, login failed. infact operations interacts user table failing. need know issue. how figure out? first clear try clear log file second make sure have not upgraded magento and 3rd make sure db accessible in magento -harry p
Read more